Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #1207

Merged
merged 1 commit into from
May 28, 2024
Merged

Bump dependencies #1207

merged 1 commit into from
May 28, 2024
+15 −15

Conversation

denyeart
Copy link
Contributor

Go to 1.22
CouchDB to 3.3.3
Fabric to 2.5.7
Fabric-CA to 1.5.10

@denyeart denyeart requested a review from a team as a code owner May 21, 2024 12:27
@denyeart
Copy link
Contributor Author

@bestbeforetoday The java chaincode lint failure here is new. This is the first test execution since the java chaincode 2.5.2 release last week, could that be the cause?

@bestbeforetoday
Copy link
Member

bestbeforetoday commented May 21, 2024 •
edited
Loading

The org.hyperledger.fabric-chaincode-java:fabric-chaincode-shim:2.5.2 release does seem to trigger this failure, although I don't obviously spot anything that changed in the chaincode-java code to cause this. It seems to be an issue with the ancient version of Mockito (5.5 years old) being used in this specific chaincode sample that fails. Updating to a newer version of Mockito makes everything happy again.

I have opened PR #1208 to update the test dependencies, which should fix this error. It solves it for me locally at least.

@denyeart denyeart closed this May 22, 2024
@denyeart denyeart reopened this May 22, 2024
@denyeart
Copy link
Contributor Author

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented May 22, 2024

rebase

✅ Branch has been successfully rebased

satota2
satota2 requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@satota2 satota2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denyeart Thank you for the PR.
This is really a minor point, but the following line should be updated as well.

fabric-samples/test-network/scripts/utils.sh

Lines 20 to 21 in d3e2a90

println " -i FabricVersion (default: '2.5.4')"
println " -cai Fabric CA Version (default: '1.5.7')"

fabric-samples/test-network/scripts/utils.sh

Lines 162 to 163 in d3e2a90

println " -i FabricVersion (default: '2.5.4')"
println " -cai Fabric CA Version (default: '1.5.7')"

I think updating with another PR is an option. Please consider it.

@denyeart
Bump dependencies
f43b87b 
Go to 1.22
CouchDB to 3.3.3
Fabric to 2.5.8
Fabric-CA to 1.5.11

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@denyeart
Copy link
Contributor Author

@satota2 Thanks for the feedback, done, I agree it is good to keep the versions updated in the same pull request so that we can easily reference them later for future updates.

satota2
satota2 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@satota2 satota2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denyeart Thank you for updating. LGTM!

@satota2 satota2 merged commit 92f028c into hyperledger:main May 28, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfi79 pfi79 pfi79 left review comments

@bestbeforetoday bestbeforetoday bestbeforetoday left review comments

@satota2 satota2 satota2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denyeart @bestbeforetoday @pfi79 @satota2